Jameson/CT-80 #66
Merged
Jameson/CT-80 #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwclemy
force-pushed
the
jameson/CT-80
branch
from
a994b05 to
c450f68
Compare
|
This change likely needs a version bump before merging though, is that correct? |
|
Yes, there is like a whole process of bumping version, publishing, etc that seems to be documented well. |
|
According to the docs it seems like this should be merged, then we do the version bumping and push that and the tag directly to master. Then we publish this to NPM. Does that sound right or am I missing something? |
|
I did step 1-3 before I merge the last time I published but I think either way would work. |
|
The code is looking good to me. |
ash-wright123
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.