Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backToSearch postmessage support #63

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

mwclemy
Copy link
Contributor

@mwclemy mwclemy commented Nov 18, 2023

This PR adds the support of a new Connect postmessage: backToSearch with context as payload.

Changes

  • I updated lib/post_message_definition.yml to add new backToSearch postmessage.
  • I run ./bin/run to execute all generators

Testing instructions

  • Checkout this branch and run npm run build in widget-post-message-definitions/packages/typescript folder

  • Update web-widget-sdk package.json file to point to a local widget-post-message-definitions package, like so: "@mxenabled/widget-post-message-definitions": "file:../widget-post-message-definitions/packages/typescript" and run npm install && npm ci && npm run build.

  • Update serenity package.json file to point to a local web-widget-sdk package, like so: "@mxenabled/web-widget-sdk": "file:../web-widget-sdk" and run npm install && npm ci && npm run dev.

  • Run this serenity branch and test the following:

    • Click add account
    • Add a manual account
    • After adding a manual account successfully, the drawer should be closed.

@codingLogan
Copy link

I tested this locally, implementing

  • widget-post-message-definitions
  • web-widget-sdk (typescript package, which consumes this change)
  • internal mm project.

Copy link

@codingLogan codingLogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the code looks good overall, as long as we have a use case for the info that we set inside of onBackToSearch.

We'll also need to make sure we properly manage the version number of the package to publish a new version. Being new to the project, I'm not sure if this was automated, or if it is a manual change.

lib/post_message_definition.yml Show resolved Hide resolved
@codingLogan
Copy link

I think the code looks good overall, as long as we have a use case for the info that we set inside of onBackToSearch.

We'll also need to make sure we properly manage the version number of the package to publish a new version. Being new to the project, I'm not sure if this was automated, or if it is a manual change.

@mwclemy https://github.com/mxenabled/widget-post-message-definitions/blob/master/packages/typescript/CONTRIBUTING.md explains the process of updating the version

Copy link

@codingLogan codingLogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, waiting for Monday before we publish a new version.

@mwclemy mwclemy merged commit d30e422 into master Nov 27, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants