Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update minVersion on vault's /config endpoint #65

Merged
merged 2 commits into from
Mar 26, 2024
Merged

fix: update minVersion on vault's /config endpoint #65

merged 2 commits into from
Mar 26, 2024

Conversation

meotch
Copy link

@meotch meotch commented Mar 26, 2024 •
edited
Loading

set min_decryption_version and min_encryption_version

Summary of Changes

use /config endpoint instead of /<named_key> endpoint to update min values

Fixes # MC-1669

Public API Additions/Changes

None

Downstream Consumer Impact

This will now properly set min values on keys so that older keys can be trimmed

How Has This Been Tested?

Validated in sand

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

meotchwilliams and others added 2 commits March 25, 2024 18:02
@meotchwilliams
fix: update minVersion on /config endpoint
fafb022 
set min_decryption_version, min_encryption_version and min_available_version
fix: drop setting min_available_version
3a40761
RyanJones08
RyanJones08 approved these changes Mar 26, 2024
View reviewed changes
Copy link

@RyanJones08 RyanJones08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@meotch meotch merged commit b75bf8e into master Mar 26, 2024
4 checks passed
@meotch meotch deleted the mitch/fix_vault_min_version branch March 26, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanJones08 RyanJones08 RyanJones08 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meotch @RyanJones08 @meotchwilliams