remove fixed column size for samples nav #1528
Open
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walesch-yan
commented
Jan 23, 2025
| @@ -845,8 +845,8 @@ class SampleListViewContainer extends React.Component { | |||
| ) : null} | |||
| <Card className="samples-grid-table-card"> | |||
| <Card.Header className="samples-grid-table-card-header"> | |||
| <Row className="samples-grid-table-row-header"> | |||
There was a problem hiding this comment.
While at it, I removed this className reference, since the css class, does not seem to exist anymore
axelboc
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
Samplespage, the column sizes of the top row including the filter and some buttons are fixed, which causes the different elements to overlap and sometimes hide features on smaller screens.This PR removes the fixed sizes, you can see the differences below for different screen sizes
Before:
Now: