Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump versions of GitHub Actions #1499

Merged
merged 4 commits into from
Nov 26, 2024
Merged

Bump versions of GitHub Actions #1499

merged 4 commits into from
Nov 26, 2024

Conversation

axelboc
Copy link
Collaborator

@axelboc axelboc commented Nov 25, 2024

There were some warnings in the GitHub UI. I went through the release notes of each action and couldn't spot any red flags: https://github.com/actions/

@axelboc
Copy link
Collaborator Author

axelboc commented Nov 25, 2024

Prettier removed a few whitespaces — let me know if you prefer I add them back.

@@ -43,7 +37,7 @@ jobs:
# Pin micromamba version because of following issue:
# https://github.com/mamba-org/setup-micromamba/issues/225
- name: "Setup conda environment with micromamba"
uses: "mamba-org/setup-micromamba@v1" # tested with v1.4.4
uses: "mamba-org/setup-micromamba@v2" # tested with v2.0.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was the one to add those comments:

Suggested change
uses: "mamba-org/setup-micromamba@v2" # tested with v2.0.1
uses: "mamba-org/setup-micromamba@v2"

I do not know if they are actually helpful or not.
Maybe we should pin everything to specific versions
and wait for Dependabot to ping us.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meh, not sure, pinning the versions and updating them via Dependabot would add a lot of noise for not much benefit IMO.

GitHub Actions follow semver very well — granted, errors always happen but the probably of a job failing because of a minor/patch update of a GitHub Action is very low.

I'd vote for removing the comment and keeping the major version tags.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am OK, with putting our trust in semver and removing the comments

Copy link
Contributor

@fabcor-maxiv fabcor-maxiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prettier removed a few whitespaces — let me know if you prefer I add them back.

It is fine. As long as all the checks are green.

But, I am confused. For some of those I do not understand why yamllint did not complain earlier...

I recall that we had what looked like a conflict between yamllint and prettier not too long ago. I am left wondering: is there something that we are missing?

@axelboc
Copy link
Collaborator Author

axelboc commented Nov 25, 2024

So the VS Code settings had a typo. Also the fix-on-save was disabled for YAML files but not for GH workflow files, which have their own "language mode"...

@marcus-oscarsson marcus-oscarsson merged commit c4423bd into develop Nov 26, 2024
19 checks passed
@marcus-oscarsson marcus-oscarsson deleted the ab-bump-actions branch November 26, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants