Clean-up and handling of deprecation warnings for pytest tests #1491
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I revisited the pytests for this repository and saw a total of 163 warnings. This PR does some clean up and reduces the number of warnings to 7.
Here is an overview of the changes in this PR:
declarative_base
import to sqlalchemy.ormTo reduce the total warnings to 7, I will make this a draft and wait on the acceptance of mxcube/mxcubecore#1077 and mxcube/mxcubecore#1072
Quick Note on the remaining 7 warnings:
Those are triggered by
passlib
using a deprecated api call forpkg_resources
. And theflask-security-too
package depends onpasslib
. Unfortunately we are already on the newest version for this package that still supportsPython 3.8
.