Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up and handling of deprecation warnings for pytest tests #1491

Merged
merged 4 commits into from
Nov 13, 2024

Conversation

walesch-yan
Copy link
Collaborator

I revisited the pytests for this repository and saw a total of 163 warnings. This PR does some clean up and reduces the number of warnings to 7.
Here is an overview of the changes in this PR:

  • Removed the unicode support for python 2.x version
  • removed an unused import
  • In the configuration files of the mockup version there were two files for beam mockup, one of them unused. Removed that one and removed the deprecated Slits from the other one.
  • Move declarative_base import to sqlalchemy.orm

To reduce the total warnings to 7, I will make this a draft and wait on the acceptance of mxcube/mxcubecore#1077 and mxcube/mxcubecore#1072

Quick Note on the remaining 7 warnings:
Those are triggered by passlib using a deprecated api call for pkg_resources. And the flask-security-too package depends on passlib. Unfortunately we are already on the newest version for this package that still supports Python 3.8.

@walesch-yan
Copy link
Collaborator Author

bumped mxcubecore version, to include the changes mentioned in mxcube/mxcubecore#1077 and mxcube/mxcubecore#1072, to now effectively reduce number of warnings to 7

@walesch-yan walesch-yan marked this pull request as ready for review November 13, 2024 08:56
@marcus-oscarsson marcus-oscarsson merged commit 714e80e into develop Nov 13, 2024
19 checks passed
@marcus-oscarsson marcus-oscarsson deleted the yw-test-cleanup branch November 13, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants