Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update auto-generated documentation #1106

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

fabcor-maxiv
Copy link
Contributor

@fabcor-maxiv fabcor-maxiv commented Oct 17, 2023

Change Sphinx theme to furo https://pypi.org/project/furo/.

Enable napoleon for handling of Google style docstrings.

Enable show-inheritance setting of autodoc.

@fabcor-maxiv
Copy link
Contributor Author

@marcus-oscarsson @rhfogh

Preview here: https://mxcubeweb--1106.org.readthedocs.build/en/1106/

And here for an example of Python API (preview): https://mxcubeweb--1106.org.readthedocs.build/en/1106/dev/autosummary/mxcube3.core.adapter.adapter_base.html

What do you think of this theme? Is it more legible?

@rhfogh
Copy link
Contributor

rhfogh commented Oct 17, 2023

Yes, this is clearer and more legible. Great Job!

@fabcor-maxiv fabcor-maxiv marked this pull request as ready for review October 18, 2023 07:13
@fabcor-maxiv fabcor-maxiv self-assigned this Oct 18, 2023
@fabcor-maxiv
Copy link
Contributor Author

@marcus-oscarsson

This is ready for merge from my point of view.

Next I will update mxcubecore to get the same matching theme.

And then I guess we are ready to work on the content and I can help with migrating the wikis to sphinx (should be simple copy-paste work), I will open a ticket for this in case we need to discuss before acting, so that we are on the same page.

Change Sphinx theme to furo `https://pypi.org/project/furo/`.

Enable napoleon for handling of Google style docstrings.

Enable `show-inheritance` setting of `autodoc`.

Remove unnecessary `templates_path` override.
@marcus-oscarsson
Copy link
Member

Yeah, thats much easier to read :)

@marcus-oscarsson marcus-oscarsson merged commit 55fc273 into mxcube:develop Oct 19, 2023
6 checks passed
@fabcor-maxiv fabcor-maxiv deleted the update-docs branch October 19, 2023 07:07
@marcus-oscarsson
Copy link
Member

By the way, I know that you played around with the themes and the last one was a great improvement. There also is this one that I think is also quite nice https://bashtage.github.io/sphinx-material/. Its maybe worth a try ?

@fabcor-maxiv
Copy link
Contributor Author

By the way, I know that you played around with the themes and the last one was a great improvement. There also is this one that I think is also quite nice https://bashtage.github.io/sphinx-material/. Its maybe worth a try ?

It looks nice. Not sure if nicer than what we have now. Maybe it is worth opening a ticket so that we do not lose the idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants