Updating queue and sample list on observers when it changes (As redux persist was removed) #1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… persist was removed)
meguiraun
reviewed
Oct 10, 2023
| } else if (record.Signal === 'update') { | ||
| const state = store.getState(); | ||
| if (!state.login.user.inControl) { | ||
| this.dispatch(fetchQueue()); |
There was a problem hiding this comment.
why not sending the queue with the emit? feels awkward to notify the UI about an update, but let the UI itself fetch the newest data
There was a problem hiding this comment.
I was thinking the same, but then I thought that it would be better to do it the same way all the time, meaning that we always fetch the queue via a http request, and we reuse the route we have in place, otherwise its like we are getting the queue in two different ways. If it makes sense
There was a problem hiding this comment.
ah yes, you have a point there
|
:) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have removed
redux-persistwhich means that updates to the queue needs to be communicated to the observers.