[ESRF Specific files] - Cleanup, deletion and linting of ESRF specific files #1123
+43
−1,615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelboc
reviewed
Feb 3, 2025
| if USER_CLICKED_EVENT and not USER_CLICKED_EVENT.ready(): | ||
| logging.getLogger("HWR").debug("DEBUG: USER_CLICKED_EVENT: false") | ||
|
|
||
| # Clear ready flag incase it was stuck |
There was a problem hiding this comment.
Suggested change
| # Clear ready flag incase it was stuck | |
| # Clear ready flag in case it was stuck |
| if x < 0 or y < 0: | ||
| for i in range(1, 18): | ||
| # logging.info("loop not found - moving back %d" % i) | ||
| logging.getLogger("HWR").info("loop not found - moving back %d" % i) |
There was a problem hiding this comment.
Suggested change
| logging.getLogger("HWR").info("loop not found - moving back %d" % i) | |
| logging.getLogger("HWR").info("loop not found - moving back %d", i) |
elmjag
reviewed
Feb 4, 2025
| move_motors(SAVED_INITIAL_POSITIONS) | ||
| raise | ||
|
|
||
| # logging.info("X=%s,Y=%s", X, Y) | ||
| # logging.getLogger("HWR").info("X=%s,Y=%s", X, Y) |
There was a problem hiding this comment.
I suggest removing this line or changing it to debug level log:
logging.getLogger("HWR").debug("X=%s,Y=%s", X, Y)
elmjag
reviewed
Feb 4, 2025
Comment on lines
+467
to
+474
| # logging.getLogger("HWR").debug(f"Click at {x}, {y}") | ||
| except Exception: | ||
| logging.exception("Exception while centring") | ||
| logging.getLogger("HWR").exception("Exception while centring") | ||
| move_motors(SAVED_INITIAL_POSITIONS) | ||
| READY_FOR_NEXT_POINT.set() | ||
| raise RuntimeError("Exception while centring") | ||
|
|
||
| # logging.info("X=%s,Y=%s", X, Y) | ||
| # logging.getLogger("HWR").debug("X=%s,Y=%s", X, Y) |
There was a problem hiding this comment.
I suggest turn the commented out debug log lines to actual code.
In principle, a verbose debug logging is not a problem. Debug logging can (should) be disabled when running in production.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup, deletion and linting of ESRF specific files: