set_value should be re-entrant adding lock to ensure reentrancy #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the pages build are failing due a depricated |
marcus-oscarsson
force-pushed
the
mo-set-value-lock
branch
from
7fc3ae8 to
b28705c
Compare
For this one, it was only yesterday that they stopped supporting it, so we were quite responsive :D We should still have paid attention to the deprecation notice I guess (where? how?), and acted before it starts breaking, though... :D |
fabcor-maxiv
approved these changes
Jan 31, 2025
marcus-oscarsson
force-pushed
the
mo-set-value-lock
branch
from
b28705c to
e01656b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set_valuecan be called multiple times and as it performs IO can be interrupted bygeventmeaning that we have to make sure that its re-entrant.