Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User-based login detailed #1115

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

dominikatrojanowska
Copy link
Contributor

At Max IV we had a meeting with beamline staff and discussed in details user-based login which is used on our site.
This MR is recap of the meeting and starting point for discussion of desired behavior of MXCuBE when user logs in.

@marcus-oscarsson
Copy link
Member

Does this describe how it works on the currently deployed installation, how you wish that it would work or how it works with the sources in the current develop, i.e something close to version 1.20x ?

@dominikatrojanowska
Copy link
Contributor Author

How Max IV staff wish that it would work. So we want to discuss here what's possible and what's not in the future mxcube

@marcus-oscarsson
Copy link
Member

marcus-oscarsson commented Jan 31, 2025

I see, I would suggest that you create an issue instead and that it could be discussed as a specific topic on user based authentication/authorization using ISPyB at MAXIV. Because this documentation should describe how things works in the current code base.

@fabcor-maxiv
Copy link
Contributor

I see, I would suggest that you create an issue instead

I was the one to suggest Dominika to start this as a pull request so that we can discuss and make changes to the Markdown document, that should act as some kind of a specification/requirements, even if we end up never merging this pull request (very likely scenario). With a GitHub issue we do not have Markdown document we can collaborate on. But whatever process gets the best discussion. :)

@fabcor-maxiv
Copy link
Contributor

fabcor-maxiv commented Jan 31, 2025

Does this describe how it works on the currently deployed installation, how you wish that it would work or how it works with the sources in the current develop

How Max IV staff wish that it would work. So we want to discuss here what's possible and what's not in the future mxcube

Yes, the idea is that on one hand we have the "wish list" from MaxIV (this document in the pull request), and on the other hand we have the reality of what is already implemented in MXCuBE and/or can/will be implemented in the near future. And we should try to find a compromise in agreement with the other facilities. What can be done in common MXCuBE-Web code, what can be done in facility-specific hardware objects and what can only be done in a fork of MXCuBE-Web?

@marcus-oscarsson
Copy link
Member

I think it would be good to initiate this discussion with a meeting. The beginning of next week will be a bit tight and we also have the general dev meeting on Tuesday. Id propose to meet either Thursday or Friday next week or sometime the week after. The general developers meeting has already a quite loaded agenda but we can start to discuss this on mxcube-web basis and the escalate the topic for next meeting.

@fabcor-maxiv
Copy link
Contributor

Oh, I did not realize that we are on mxcubecore. Maybe this should have been on mxcubeweb, no?

@marcus-oscarsson
Copy link
Member

Its a functionality that is shared between the applications so I think its fine.

@marcus-oscarsson marcus-oscarsson marked this pull request as draft January 31, 2025 13:47
@marcus-oscarsson
Copy link
Member

Converting to draft, its easier to see what is pending to be merged like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants