Rhfogh develop #1029
Merged
Rhfogh develop #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2022,6 +2022,9 @@ def __init__(self): | |||
| self.acquisition_dose = 0.0 | |||
| self.strategy_length = 0.0 | |||
|
|
|||
| # Workflow attributes - for passing to LIMS (conf Olof Svensson) | |||
There was a problem hiding this comment.
What does "(conf Olof Svensson)" mean ?
There was a problem hiding this comment.
This is code that 1) is used on Massif-1 but not anywhere else or by thw main develop version; 2) is still provisional, since the ICAT LIMS and connections ro it (as I understand it) are still not stable or documented. I have coded this so that it will work (but do nothing) in the main develop branch, and put it there to make it easier to track what is going on and avoid having a completely different branch for MASSIF-1.
Anyway, that is what it means.
marcus-oscarsson
force-pushed
the
rhfogh_develop
branch
from
d502e3f to
1716a98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug in GPhL workflow recentring handling.
Also added provisional code for integration with ESRF workflow and LIMS. NB this code is specific to GPhL workflow and only executed when relevant code is present on the main MXCuBE side - so, in practice - a no-op.