Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped Pydantic #1025

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Bumped Pydantic #1025

merged 1 commit into from
Sep 27, 2024

Conversation

marcus-oscarsson
Copy link
Member

@marcus-oscarsson marcus-oscarsson commented Sep 19, 2024

Bumped Pydantic.

@oldfielj-ansto (or anyone else for that matter :) ), we are currently using the pydantic.v1 package. Do you see any immediate issue with that ? We hope that we can get rid of this import relatively soon but we need to stay compatible with spectree which until now requires pydantic.v1

@fabcor-maxiv
Copy link
Contributor

I hope we find time to test this

@marcus-oscarsson
Copy link
Member Author

marcus-oscarsson commented Sep 19, 2024

Initial testing looks, good. There should not be any change since we are using the pydantic.v1 package. See https://docs.pydantic.dev/latest/migration/#install-pydantic-v2 for more information. We will need to change some model definitions when we are no longer using pydantic.v1. I did test that as well and it seems to work but it is indeed a bit of a bigger change that needs even more testing.

@marcus-oscarsson marcus-oscarsson merged commit 9d89967 into develop Sep 27, 2024
11 checks passed
@marcus-oscarsson marcus-oscarsson deleted the mo-pydantic branch September 27, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants