Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ChannelSftp.java #425

Closed
wants to merge 3 commits into from
Closed

Update ChannelSftp.java #425

wants to merge 3 commits into from

Conversation

mironabr
Copy link

@mironabr mironabr commented Nov 5, 2023

flush

pom.xml Outdated
@@ -2,7 +2,7 @@
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<groupId>com.github.mwiede</groupId>
<artifactId>jsch</artifactId>
<artifactId>k2-jsch</artifactId>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was added by mistake right?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. Currently we are using our fork in our code.

@mwiede
Copy link
Owner

mwiede commented Nov 7, 2023

@mironabr as said in #411 can we have a failing integration test which this PR would solve?

@mironabr
Copy link
Author

mironabr commented Nov 7, 2023

@mironabr as said in #411 can we have a failing integration test which this PR would solve?

It is difficult to do that. The issue does not happen any time. I does not happen on any SFTP server. I guess it depend on the SFTP server type/configuration. It happen on our local test servers. I saw lot of talking about it over the internet

@mironabr mironabr requested a review from mwiede November 8, 2023 08:03
@mwiede
Copy link
Owner

mwiede commented Nov 13, 2023

we took the change in 86bc2e6 so I will close this PR

@mwiede mwiede closed this Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants