-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Docker image building and add Docker info to docs #562
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
d6f3561
Fix docs build dependencies
DonnchaC 6e0cd23
Add license to Docker image metadata
DonnchaC 4598293
Generate ADB key on first run to avoid static key in image
DonnchaC cbb78b7
Update pip version in image to try fix package build issue
DonnchaC 62cdfa1
Add info to docs on using docker image
DonnchaC 319bc7e
Switch docker build to use local context rather than pulling
DonnchaC 37705d1
Add checksum for ABE jar
DonnchaC 7772d2d
Add build dependencies for pyahocorasick
DonnchaC 17b625f
Make multiplatform images
DonnchaC 83c1bbf
Revert "Make multiplatform images"
DonnchaC File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
mkdocs==1.2.3 | ||
mkdocs-autorefs | ||
mkdocs-material | ||
mkdocs-material-extensions | ||
mkdocstrings | ||
mkdocs==1.6.1 | ||
mkdocs-autorefs==1.2.0 | ||
mkdocs-material==9.5.42 | ||
mkdocs-material-extensions==1.3.1 | ||
mkdocstrings==0.23.0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doing this will make the repository files inaccessible in the final image, but they will still take up space in the intermediate layers. If you are willing to require BuildKit to build the Dockerfiles (the default on Linux since Febuary 2023 and easily enabled much further back), you can use the
--mount
option ofRUN
(https://docs.docker.com/reference/dockerfile/#run---mount) to pip install from the build context without saving unnecessary data in the image.