Showing data in the UI again, ignoring timestamps for now #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d to be made in onMessageArrived.
mvolkmann
reviewed
Jul 1, 2017
src/App.js
Outdated
| @@ -13,16 +13,15 @@ const manifolds = {}; | |||
| let dirty = false; | |||
|
|
|||
| function bytesToNumber(buffer) { | |||
| // const bytes = new Uint8Array(buffer); | |||
There was a problem hiding this comment.
Looks like you don't need this commented out line since there is an uncommented copy right below it.
mvolkmann
reviewed
Jul 1, 2017
src/App.js
Outdated
| @@ -117,9 +117,13 @@ class App extends Component { | |||
|
|
|||
| // If the field in the message is not one we care about ... | |||
| if (!prop) return; | |||
| // @TODO parse messages. | |||
| // At this point a message has been recieved from the message broker | |||
mvolkmann
reviewed
Jul 1, 2017
| @@ -132,7 +136,8 @@ class App extends Component { | |||
| client.onMessageArrived = onMessageArrived; | |||
|
|
|||
| // Documentation on the message object is at | |||
| // https://www.eclipse.org/paho/files/jsdoc/symbols/Paho.MQTT.Message.html#duplicate | |||
| // https://www.eclipse.org/paho/files/jsdoc/symbols/Paho.MQTT.Message.html | |||
| // #duplicate | |||
mvolkmann
approved these changes
Jul 1, 2017
|
Sorry I've been so slow at looking at this. I've been really busy on my
Monsanto project.
Glad to see you're digging in!
…On Thu, Jun 29, 2017 at 1:25 PM, Jeremy Plack ***@***.***> wrote:
------------------------------
You can view, comment on, or merge this pull request online at:
#1
Commit Summary
- fixes UI updating.
- adds comment explaining modification to mqtt client.
- modification to client _getPayloadString method, adds note for
updated to be made in onMessageArrived.
- read data from buffer - timestamp.
File Changes
- *A* .eslintignore
<https://github.com/mvolkmann/iiot-demo/pull/1/files#diff-0> (1)
- *M* .eslintrc.json
<https://github.com/mvolkmann/iiot-demo/pull/1/files#diff-1> (6)
- *M* lib/mqttws31.js
<https://github.com/mvolkmann/iiot-demo/pull/1/files#diff-2> (825)
- *M* package.json
<https://github.com/mvolkmann/iiot-demo/pull/1/files#diff-3> (1)
- *M* public/config.json
<https://github.com/mvolkmann/iiot-demo/pull/1/files#diff-4> (4)
- *M* src/App.js
<https://github.com/mvolkmann/iiot-demo/pull/1/files#diff-5> (62)
Patch Links:
- https://github.com/mvolkmann/iiot-demo/pull/1.patch
- https://github.com/mvolkmann/iiot-demo/pull/1.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAE10M7O6_ZFmi_QzI9B33HkmZrVZIzGks5sI-wHgaJpZM4OJsVS>
.
--
R. Mark Volkmann
Object Computing, Inc.
|
|
Hi Mark, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.