Fix social links breaking over multiple lines like "(icon)\n@dflemstr" #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The GitHub icon is still on line 1 on a 1366 x 768 screen in Chrome/Ubuntu. |
|
I can change my username on Twitter and GitHub ;) |
|
Alternate method used now. |
|
The layout goes berzerk on my phone in landscape mode (and in a certain width of the browser) |
|
Hm... maybe let's just not fix this? :) |
|
Ok. Then let's update version and merge. |
|
No I meant as in closing this change and letting the problem exist.... |
|
I just realized that the problem i mentioned already exists in the current version. So it might be better to go ahead and make these changes, to make it look better most of the time. |
|
So.. should we merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Poor @michaelhakansson gets his links messed up like this:
This fixes that problem.