Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring infrastructure #27

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

kkeker
Copy link

@kkeker kkeker commented Jan 30, 2020

  • Change base image (Oracle Entreprise Linux 8).
  • Improved the use of variables.
  • Redid the installation of python packages on pip.
  • Redid installing jvm components on sdkman.

kkeker and others added 2 commits January 30, 2020 12:50
Copy link

@osleonard osleonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor but a little comment

docker-compose.yml Outdated Show resolved Hide resolved
@EmileSonneveld
Copy link

I like how $SPARK_HOME is used here. It makes things more clear for me.

@kkeker
Copy link
Author

kkeker commented Dec 13, 2022

I like how $SPARK_HOME is used here. It makes things more clear for me.

The main application in these containers is Spark, so it's important to know where it's installed.
If you need to enter a container, the SPARK_HOME directory will be used as the base directory when you enter, thanks to WORKDIR ${SPARK_HOME}, this will make it easy to see the installed components simply by using ls or running commands from the relative path ./. Also, the main process startup scripts use this variable instead of the hardcoded absolute paths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants