Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix validations #94

Merged
merged 3 commits into from
Mar 4, 2022
Merged

Fix validations #94

merged 3 commits into from
Mar 4, 2022

Conversation

sajadhsm
Copy link
Contributor

This PR address some issues listed in #92:

  1. Login and register page route guards (Currently we can move to the login page by typing the address in the URL bar even when we are already logged in)

  2. mapValidationResponse does not handle 403 error

403

  • This behavior is not documented in the Swagger but checking the official API code confirms that. (Maybe a PR should be made on that repo and update the docs too)
  1. Reset errors when re-submitting the forms

@vercel
Copy link

vercel bot commented Feb 28, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/mutoe/vue3-realworld-example-app/EWTZZxqZopGiXBgeGqYGPNQKnrqA
✅ Preview: https://vue3-realworld-example-app-git-fork-sajadhsm-fix-v-3d22b3-mutoe.vercel.app

@mutoe mutoe merged commit 34aa39b into mutoe:master Mar 4, 2022
@sajadhsm sajadhsm deleted the fix-validations branch March 5, 2022 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mutoe mutoe mutoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sajadhsm @mutoe