Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor code improvements #93

Merged
merged 5 commits into from
Mar 4, 2022
Merged

Conversation

sajadhsm
Copy link
Contributor

This PR address some of the issues listed in #92:

  • No need to write <template #default> for suspense
  • useArticles composable:
    • In fetchArticles function, since articleType can only have one value, it's better to use if-else rather than only if to skip other checks.
    • getArticlesMeta function is acting like a composable. So maybe it's better to rename it to useArticlesMeta
  • Vue docs doesn't recommend using generic argument for reactive(). So it may be better to change current generic usage.
  • In AppLink component, useAttrs and v-bind="attrs" can be removed because of Fallthrough Attributes

@vercel
Copy link

vercel bot commented Feb 27, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/mutoe/vue3-realworld-example-app/HwemJ4c1L3jJPxs2da2zSDD2b7Ft
✅ Preview: https://vue3-realworld-example-app-git-fork-sajadhsm-minor-689858-mutoe.vercel.app

@mutoe
Copy link
Owner

mutoe commented Mar 4, 2022

Thanks for your contribution! 😄️

A little tip: you can use the refactor prefix with your commit message when you are doing something that is refactoring or cleaning up the code.

https://github.com/angular/angular/blob/master/CONTRIBUTING.md#-commit-message-format

@sajadhsm sajadhsm deleted the minor-code-improvements branch March 5, 2022 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants