Zeroing nanslices #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aNs to zero. If this is not set, the code fails and there are valid reasons for why one might want to have cubes all with NaNs (fixed OUTPUT_WCS for instance). It is debatable whether this should always be on (ie. have a default of True). Since not doing this, causes the code to fail, I have opted to set this by default to True.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some situations, we create MUSE cubes that have all NaN slices. This is particularly the case with fixed OUTPUT_WCS situations. This proposed change, adds a zero_nan_slices option to
processandZapwhich is set to True by default and which sets any slice that is filled with NaNs will be set to zeros. This is identical to how the laser gaps are treated.After cleaning the NaNs are reinserted, again just as for the laser gaps.
Do note that this is now on by default - if not, these cubes are not possible to process so this does not really break any backwards compatability.