fix: v-scroll directive event listener leak #1365
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a heavy event listener leak when using
v-scroll
directive.The performance profile was captured in https://muse-ui.org/#/zh-CN/directives . When the page scrolls, there's just tons of event listeners been attached, but none of them got removed.
https://github.com/museui/muse-ui/blob/master/src/internal/directives/scroll.js#L38
I think the
update
function in this directive was totally unnecessary, according to Vue Custom Directive Guide.To demonstrate this, there's a fiddle: https://jsfiddle.net/zgrxt69h/ .
update
was removed, and it still works fine.