Improvements and sf3 import #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integration improvement (fix musescore#11): * preprocessor variable to loose the xml and libsnd dependencies * namespace SfTools * smallSf now a class variable * C++11 not needed anymore (struct initialization) * dynamic declaration of array now ok with visual C++ (fix musescore#10) * warning and unused variables removed Bug fix: * sample links now kept in the soundfont (fix musescore#9)
Now possible to convert back from sf3 to sf2 (option y) Soundfont 2.04 can be converted also (sm24 chunk was rejected) The attenuation before compressing is stored as a comment in the ogg data so that the attenuation can be reverted when uncompressing it Adapted the documentation
Fix a bug: the iver and irom don't stop the conversion
|
@davy7125 the code on the your branch doesn't compile. sfconvert.cpp is missing semicolons at lines 121-122, and sf.smallSf does not exist at line 131. |
|
Also, I converted an SF3 of mine back to SF2 and it sounds terrible, nothing like the original SF2 (or SF3). |
|
Seems a rebase is needed to fix merge conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration improvement (fix #11):
Bug fix:
New feature:
Improvement: