Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sample links are removed #9

Open
davy7125 opened this issue Sep 7, 2015 · 1 comment · May be fixed by #31
Open

sample links are removed #9

davy7125 opened this issue Sep 7, 2015 · 1 comment · May be fixed by #31

Comments

@davy7125
Copy link

davy7125 commented Sep 7, 2015

Hi,

Sample links are lost while exporting as Sf3. This appears to be done on purpose but I don't know which one.

If it's related to the idea of compressing both left and right samples together, I think it's a bad idea since sf2 format is based on mono samples (played together but 2 distinct mono samples). All sf2 players take into account mono samples to play and if you merge these samples you would force developers to dissociate them first, so that the sf3 format can be read. Two parts of a stereo sample, once imported in a soundfont, may be played completely differently depending on what parameter we put.
mirabilos added a commit to mirabilos/sftools that referenced this issue Mar 13, 2018
@mirabilos
add note that sample links are removed
bd2ba6b 
from musescore#9
@lasconic
Copy link
Contributor

@mirabilos added a note about it, but I still don't know why links are removed. Only @wschweer would know.

@davy7125 davy7125 mentioned this issue Nov 5, 2018
Closed
davy7125 added a commit to davy7125/sftools that referenced this issue Aug 30, 2020
@davy7125
Integration and sample links
9ea109e 
Integration improvement (fix musescore#11):
* preprocessor variable to loose the xml and libsnd dependencies
* namespace SfTools
* smallSf now a class variable
* C++11 not needed anymore (struct initialization)
* dynamic declaration of array now ok with visual C++ (fix musescore#10)
* warning and unused variables removed

Bug fix:
* sample links now kept in the soundfont (fix musescore#9)
@davy7125 davy7125 linked a pull request Aug 30, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improvements and sf3 import davy7125/sftools
Integration and sample links
2 participants
@lasconic @davy7125