Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code improvements #11

Open
davy7125 opened this issue Sep 7, 2015 · 0 comments · May be fixed by #31
Open

Code improvements #11

davy7125 opened this issue Sep 7, 2015 · 0 comments · May be fixed by #31

Comments

@davy7125
Copy link

davy7125 commented Sep 7, 2015

Hi,

Several non-critical things:

  • the following dependencies could be avoided if you remove non essential functions: xml module of Qt, libsndfile,
  • C++11 could be avoided by rewriting the initialization of a structure,
  • warnings could be removed (memset(&p, sizeof(p), 0); / unused variables),
  • a namespace is missing,
  • readCompressedSample is dead code.
@davy7125 davy7125 mentioned this issue Nov 5, 2018
Closed
davy7125 added a commit to davy7125/sftools that referenced this issue Aug 30, 2020
@davy7125
Integration and sample links
9ea109e 
Integration improvement (fix musescore#11):
* preprocessor variable to loose the xml and libsnd dependencies
* namespace SfTools
* smallSf now a class variable
* C++11 not needed anymore (struct initialization)
* dynamic declaration of array now ok with visual C++ (fix musescore#10)
* warning and unused variables removed

Bug fix:
* sample links now kept in the soundfont (fix musescore#9)
@davy7125 davy7125 linked a pull request Aug 30, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improvements and sf3 import davy7125/sftools
Integration and sample links
1 participant
@davy7125