Score popups focus fix

[Eism]

Resolves: #26018

[bkunda]

This is all feeling pretty good to me!

One problem though is that the shift-to-move-beat-position interaction only seems to work if you select the dynamic with the mouse. It doesn't work if you select the dynamic via keyboard navigation or after having just inputted it via either the popup or the input text field.

Screen.Recording.2025-01-23.at.1.42.18.pm.mov

Also doesn't work if you add the dynamic from the palette:

Screen.Recording.2025-01-23.at.1.55.17.pm.mov

[Eism]

@bkunda
let's fix this in a separate PR. I see that these problems also exist in all other elements

[avvvvve]

@Eism When you click on a dynamic to select it, Alt/Option + Left/Right arrow will no longer move the selection to the next/previous element. Instead, it nudges it to the left/right as if just an arrow with no modifier was pressed.

• The same happens even if you get the popup to disappear by some means and then try to Alt + Arrow, i.e....
  • Scrolling the score to close the popup
  • Move focus to the popup with the keyboard, change the dynamic, press esc to close the popup leaving the dynamic selected (shown in the video at 0:11)

Alt + Left/Right does nothing when focus is on the popup (shown at 0:25). It should move selection to previous/next as usual, closing the popup in the process.

Screen.Recording.2025-01-23.at.11.08.47.AM.mov

I'll leave it up to you if we should solve this in another PR or here.

And sorry, thought I sent a comment earlier but I must've forgotten to submit it!

[avvvvve]

@Eism The other changes you noted in the issue this fixes look good, but it looks like #4 is still unresolved.

Pasting the original comment here:
The order of the "ppppp pppp ppp" and the crescendo/decrescendo pages should be swapped, so when you move left from the first page, you get to the "ppppp ..." page. Left again would take you to cres/dec. (Oversight on my part, updated figma with the correct order)

[Eism]

@avvvvve
Thanks for the test

Alt/Option + Left/Right arrow will no longer move the selection to the next/previous element

I can reproduce Alt/Option + Left/Right arrow issue and it is the same issue as for shift-to-move-beat-position interaction. Let's create a separate issue for it (which includes both issues) because I can reproduce this issue for other elements as well

Alt + Left/Right does nothing when focus is on the popup

Do we really want this behavior?
If the user tabbed to a popup, then I think it's expected that the user can't do anything with the element, because the focus isn't on the element now.

it looks like 4 is still unresolved

Make sure you are using the correct build because I see the correct order in my latest build

[avvvvve]

Ah, must've had the wrong build. The page order looks right!

Re:

Do we really want this behavior?
If the user tabbed to a popup, then I think it's expected that the user can't do anything with the element, because the focus isn't on the element now.

I understand that technically the dynamic isn't focused, but it still looks selected. To me, it ends up feeling broken if I can't use a keyboard shortcut because I'm in a "special" state. Another example I just noticed: if I've used tab to focus into the popup, I'd still expect to be able to Copy the dynamic (which should not close the popup) or even Cut it (which should close the popup), but neither of those work.

Yes, you can hit esc first and then do any of these commands, but ideally it would not take that extra step.

Strangely, the voice assignment shortcuts (i.e. Alt + Ctrl + [1,2,3,4,0,-]) DO work while focus is inside the popup. That makes me think it's possible to do and we should follow suit for other key commands.

---

I think we can lump that in with the other shift/option issues mentioned above, so I'll open a follow-up issue for that!