Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revised & translated the sources in instuments_ko.ts file to Korean #25465

Closed
wants to merge 4 commits into from

Conversation

lighteko
Copy link

@lighteko lighteko commented Nov 8, 2024

I translated every sources in instruments_ko.ts file to Korean. There were several unnatural translations, so I fixed them as well.

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@Jojo-Schmitz
Copy link
Contributor

Translations are done on Transifex, not via PRs

@lighteko lighteko closed this Nov 8, 2024
@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Nov 8, 2024

@cbjeukendrup might be able to grab this and upload to Transifex in one go and that way save you the work from having to do it all again there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants