-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breve-rest corrections #25374
Breve-rest corrections #25374
Conversation
I think you should include more of the visual tests I added in #25295. In particular, there are currently no visual tests for when
In addition, I added Ultimately, because there have until now been no regression tests for when |
src/engraving/dom/rest.cpp
Outdated
@@ -486,17 +486,18 @@ int Rest::computeVoiceOffset(int lines, LayoutData* ldata) const | |||
|
|||
int Rest::computeWholeRestOffset(int voiceOffset, int lines) const |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my version of this PR, I changed the name from computeWholeRestOffset
to computeWholeOrBreveRestOffset
, to reflect what its new function is.
41c2a50
to
39d2fc3
Compare
Resolves: #25246
Resolves: #25294
This is a stripped down version of #25295.