fix(time signatures): adding a time signature does not deselect current measure(s) #24891
Conversation
… bugfix-select-timesig-on-add-timesig
|
Isn't this a duplicate of #24892 (or vice versa)? |
Yes, this is the correct one because it merges into master |
src/engraving/dom/edit.cpp
Outdated
| } | ||
| } | ||
| std::pair<staff_idx_t, staff_idx_t> staffIdxRange = getStaffIdxRange(score); | ||
| for (staff_idx_t si = staffIdxRange.first; si < staffIdxRange.second; ++si) { | ||
| TimeSig* nsig = toTimeSig(seg->element(si * VOICES)); | ||
| if (!nsig) { | ||
| TimeSig* newSig = toTimeSig(seg->element(si * VOICES)); |
There was a problem hiding this comment.
better newTimeSig to differentiate from key signatures
src/engraving/dom/edit.cpp
Outdated
| Fraction ns = ts->sig(); | ||
| Fraction tick = fm->tick(); | ||
| TimeSig* lts = staff(staffIdx)->timeSig(tick); | ||
| Fraction newSigFraction = timeSig->sig(); |
There was a problem hiding this comment.
Better newTimeSigFraction
There was a problem hiding this comment.
also loose the extra space, unless using them for alignment
|
This is a draft btw, you don't have to review now! I thought the convention was to mark as 'ready for review' when I am ready for review @Jojo-Schmitz |
| mf->undoChangeProperty(Pid::TIMESIG_NOMINAL, newSigFraction); | ||
| Measure* currentMeasure = mf->nextMeasure(); | ||
| Segment* segment = currentMeasure->findSegment(SegmentType::TimeSig, currentMeasure->tick()); | ||
| mf = segment ? 0 : mf->nextMeasure(); |
There was a problem hiding this comment.
@Jojo-Schmitz Any idea what this 'mf' is supposed to refer to?
There was a problem hiding this comment.
To do with steming from master score I guess?
…following comments
Resolves: #9584