Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed resolve ui context (project opened) #24887

Merged
merged 1 commit into from
Sep 23, 2024
Merged

fixed resolve ui context (project opened) #24887

merged 1 commit into from
Sep 23, 2024

Conversation

igorkorsukov
Copy link
Contributor

Resolves: #24673

cbjeukendrup
cbjeukendrup approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@cbjeukendrup cbjeukendrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me, but will of course need proper regression checking (for example, is there no unexpected behaviour when trying to copy text in a dialog while there is also a selection on a score; stuff like that).

@DmitryArefiev DmitryArefiev self-assigned this Sep 23, 2024
@DmitryArefiev
Copy link
Contributor

need proper regression checking (for example, is there no unexpected behaviour when trying to copy text in a dialog while there is also a selection on a score; stuff like that).

Tested briefly on Win/Mac - no regressions found

@DmitryArefiev DmitryArefiev merged commit 090793d into musescore:master Sep 23, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbjeukendrup cbjeukendrup cbjeukendrup approved these changes

Assignees

@DmitryArefiev DmitryArefiev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cmd() does not work anymore in plugins
3 participants
@igorkorsukov @DmitryArefiev @cbjeukendrup