-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[extensions] Added the ability to add buttons to the toolbar #24833
base: master
Are you sure you want to change the base?
Conversation
Do I see it right that this allows for a Save button to get added to the toolbar? |
Yes ;) |
src/framework/ui/view/iconcodes.h
Outdated
int enumIndex = staticMetaObject.indexOfEnumerator("Code"); | ||
QMetaEnum me = staticMetaObject.enumerator(enumIndex); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps QMetaEnum::fromType<Code>()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't we utilise StyledToolBarView
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
implementation changed to using StyledToolBarView
b8f992d
to
5ca1ef7
Compare
Screencast.from.2024-09-20.11-42-12.webm