Calculate up for user modified tremolos #24818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miiizen
force-pushed
the
27486-trem-up
branch
from
31e1583
to
27bcaec
Compare
oktophonie
approved these changes
Sep 20, 2024
mike-spa
approved these changes
Sep 27, 2024
miiizen
force-pushed
the
27486-trem-up
branch
2 times, most recently
from
878cb7e
to
27fe07c
Compare
miiizen
force-pushed
the
27486-trem-up
branch
from
27fe07c
to
93b0771
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #24786
Resolves: #24241
The direction of user modified tremolos was never calculated properly. We now set each chord's direction based on if it is above or below the tremolo.