fixed stretched bend crash #24785
Merged
fixed stretched bend crash #24785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikekirin
approved these changes
Sep 18, 2024
|
Any idea why there is a wrong data? |
it's just because it's not filled yet when it's being addressed. |
abariska
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(with --gp-experimental flag)
if untilNextSegment is false, it's wrong to adjust coordinates by X. And it can lead to crash cause the segments of another bend may not be filled (ASSERT added)
It's being adjusted after bend is already layouted for the first time with chord, when fillStretchedSegments is called with untilNextSegment = true.
crash.gp.zip