Limit barline span #24773
Merged
Limit barline span #24773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-spa
force-pushed
the
limitBarlineSpan
branch
from
fccc819
to
f959468
Compare
Don't add to it the "spanFrom" value of the next barline.
mike-spa
force-pushed
the
limitBarlineSpan
branch
from
f959468
to
d757a44
Compare
oktophonie
approved these changes
Sep 18, 2024
miiizen
approved these changes
Sep 18, 2024
mike-spa
added a commit
to mike-spa/MuseScore
that referenced
this pull request
Sep 20, 2024
Limit barline span
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #24770
The span was intentionally adjusted to also cover the
spanFromvalue of the barline of the next staff, but that doesn't probably make much sense. Better to simply stop at the edge of the next staff.