Fix hairpin aperture not saved #24771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oktophonie
approved these changes
Sep 17, 2024
mike-spa
force-pushed
the
fixHairpinApertureNotSaved
branch
from
3769812
to
73e7a3e
Compare
4 tasks
It was removed in e45996b
mike-spa
force-pushed
the
fixHairpinApertureNotSaved
branch
from
aea0767
to
ecbb61f
Compare
mathesoncalum
approved these changes
Sep 18, 2024
mike-spa
added a commit
to mike-spa/MuseScore
that referenced
this pull request
Sep 20, 2024
…tSaved Fix hairpin aperture not saved
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #24737
The issue is two-fold.
unstyledand therefore wasn't saved. This is not a 4.4 issue and in fact it dates back to at least version 3.6. The reason is that the user is drag-editing a HairpinSegment, but the relevant property (the aperture) belongs to the Hairpin, so the relevant propertyFlag wasn't correctly set.