Percussion panel - layout and interaction basics #24753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/notation/view/percussionpanel/percussionpanelpadlistmodel.cpp
Outdated
Show resolved
Hide resolved
src/notation/view/percussionpanel/percussionpanelpadlistmodel.h
Outdated
Show resolved
Hide resolved
src/notation/view/percussionpanel/percussionpanelpadlistmodel.cpp
Outdated
Show resolved
Hide resolved
src/notation/view/percussionpanel/percussionpanelpadlistmodel.h
Outdated
Show resolved
Hide resolved
src/notation/view/percussionpanel/percussionpanelpadlistmodel.cpp
Outdated
Show resolved
Hide resolved
src/notation/view/percussionpanel/percussionpanelpadlistmodel.cpp
Outdated
Show resolved
Hide resolved
src/notation/qml/MuseScore/NotationScene/internal/PercussionPanelPad.qml
Outdated
Show resolved
Hide resolved
mathesoncalum
force-pushed
the
percussions_layout
branch
3 times, most recently
from
f162ddb
to
1ee6840
Compare
src/notation/view/percussionpanel/percussionpanelpadlistmodel.cpp
Outdated
Show resolved
Hide resolved
src/notation/qml/MuseScore/NotationScene/internal/PercussionPanelPad.qml
Show resolved
Hide resolved
src/notation/qml/MuseScore/NotationScene/internal/PercussionPanelPad.qml
Outdated
Show resolved
Hide resolved
src/notation/qml/MuseScore/NotationScene/internal/PercussionPanelToolBar.qml
Outdated
Show resolved
Hide resolved
src/notation/view/percussionpanel/percussionpanelpadlistmodel.cpp
Outdated
Show resolved
Hide resolved
src/notation/view/percussionpanel/percussionpanelpadlistmodel.cpp
Outdated
Show resolved
Hide resolved
src/notation/view/percussionpanel/percussionpanelpadlistmodel.h
Outdated
Show resolved
Hide resolved
src/notation/qml/MuseScore/NotationScene/internal/PercussionPanelToolBar.qml
Show resolved
Hide resolved
mathesoncalum
force-pushed
the
percussions_layout
branch
from
1ee6840
to
973888f
Compare
RomanPudashkin
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some things to note:
There is no interaction with the score yet (hence why an example/placeholder kit is used). This PR focuses purely on the panel layout and UX basics.
The “toolbar” (Write, Preview, etc.) is placed within the percussion panel area in this PR. This is expected as we first need to merge #22050 to place these controls in the
DockFrame.To summarise the interactions/responsibilities of the new components:
PercussionPanelPadModelwill maintain all data relevant to single pad (currently this only consists of the instrument name),PercussionPanelPadListModelwill handle the initialisation of pads in the grid (and any layout editing), and thePercussionPanelModelhandles panel modes (and eventually score interactions).