Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Undo/Redo naming and history #24744

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rpatters1
Copy link

Resolves: #24509

  • Adds a name for every call to UndoStack::beginMacro and displays these names in the menu and palettes.
  • Adds Undo/Redo History to the Edit Menu and a dialog box to allow cycling through the history. This dialog box copies the simple single-list approach used by Dorico rather than the more complex dialog box used by Finale. Anyone who knows how to use the Dorico undo history should know immediately how to use this.

This PR incorporates the changes in #24543. I made a slight modification in UndoRedoModel::load to remove code duplication. Please review that part carefully, @cbjeukendrup.

The PR replaces #24587, and that PR is now closed.

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@rpatters1 rpatters1 force-pushed the rpatters1/undo-history-phase-2 branch 2 times, most recently from 8ef5add to f281ec8 Compare September 19, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Undo Text and Undo History
1 participant