Add voice assignment to MEI support #24735
Open
+116
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| libmei::xsdPositiveInteger_List staffList; | ||
| staffList.push_back(item->staff()->idx() + 1); | ||
| // TODO: add staff number if centered between staves |
There was a problem hiding this comment.
Should the 'discriminating factor' really be whether the number is centered between staves, or should it be when the voice assignment is set to ALL_VOICE_IN_INSTRUMENT?
It might be relatively easily to implement using item->part()->staveIdxList().
There was a problem hiding this comment.
Information in the @staff attribute is more of a visual nature, i.e. staff="2 3" means something appears on staff 2 and staff 3, and has to be accompanied by a pleace="between". I'll look into this later.
rettinghaus
force-pushed
the
mei/voice
branch
from
925405c
to
368174d
Compare
rettinghaus
force-pushed
the
mei/voice
branch
from
368174d
to
fcbca57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds basic support for voiceAssignment in MEI import/export. For this to some control elements the recommended @staff attribute is added, and additionally the voice is exported to the
@layerattribute, if a danymic or hairpin is assigned to a specific voice.Resolves: #24471