Fix MSVC compiler warnings #24672
Merged
Fix MSVC compiler warnings #24672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Jojo-Schmitz
commented
Sep 12, 2024
•
Jojo-Schmitz
commented
- reg.: conversion from 'size_t' to 'xxx', possible loss of data (C4267)
- reg.: declaration of 'part' hides previous local declaration (C4456)
Jojo-Schmitz
force-pushed
the
compiler-warnings
branch
2 times, most recently
from
4c79803
to
d2d325c
Compare
Jojo-Schmitz
force-pushed
the
compiler-warnings
branch
from
d2d325c
to
cdd122f
Compare
Jojo-Schmitz
force-pushed
the
compiler-warnings
branch
2 times, most recently
from
14c7ba8
to
39ab57e
Compare
Jojo-Schmitz
force-pushed
the
compiler-warnings
branch
4 times, most recently
from
1340aeb
to
f90e186
Compare
reg.: conversion from 'size_t' to 'xxx', possible loss of data (C4267)
reg.: declaration of 'part' hides previous local declaration (C4456)
Jojo-Schmitz
force-pushed
the
compiler-warnings
branch
from
f90e186
to
86885ce
Compare
|
Seems this PR got ignored since a month now? |
|
Sorry, it was overlooked |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.