Fix spanner issues with join measures #24623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oktophonie
approved these changes
Sep 12, 2024
miiizen
force-pushed
the
24496-spanner-join
branch
from
f0a79c4
to
6019600
Compare
RomanPudashkin
approved these changes
Sep 12, 2024
Merged
mike-spa
approved these changes
Sep 12, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #24496
Resolves: #23030
Spanners weren't being adjusted properly on removing measures. I've made sure this happens, and added accounted for some edge cases for spanners starting outside and ending inside and starting inside and ending outside a joined range.