Fix GH#24553: MusicXML: A title like "Jazz Piece No. 5" get interpreted as a subtitle

[Jojo-Schmitz]

Resolves: #24553

Turned out to be a rather simple off-by-one error, @miiizen ?

Edit: Apparently not, but let's not try it infer anything from a title if it is just one line.

[cbjeukendrup]

Note that the exact functionality is still different than before 0ea3638.

Before:
when one line is encountered that is likely credit/subtitle text, then that line and all lines below it are moved to credit/subtitle text.

After:
when one line is encountered that is likely credit/subtitle text, only that line is moved.

[Jojo-Schmitz]

Question is whether that is better or not, isn't it?

[cbjeukendrup]

That's up to @miiizen and @oktophonie.

[Jojo-Schmitz]

of course it is ;-)

[Jojo-Schmitz]

Can we have this reviewed please?

Ported to 4.4.3, see #24750

[miiizen]

I can see the problem here, but I don't think this is the way we should fix it. I'd prefer to prevent this situation either:

• by not inferring subtitles or credits when there is only one line of text
• or, if after inference we end up with an empty title, promote the first line back to title

[Jojo-Schmitz]

Isn't my change doing exactly not inferring subtitles or credits when there is only one line of text ? It just skips the loop if there's only one line

[miiizen]

We'd still like to check if the first line of a title would be better suited to a subtitle when there is more than one line.

[Jojo-Schmitz]

Which again would leave the score without a title

[miiizen]

If I set the title to this:

<work>
  <work-title>Jazz Piece No. 5
  rest of title</work-title>
</work>

I get the following, which is what we'd prefer!

[Jojo-Schmitz]

So something like this would pass muster?

    size_t nrOfTitleLines = titleLines.size();
    if (nrOfTitleLines == 1) {
        return;
    }
    for (size_t i = nrOfTitleLines; i > 0; --i) {
    ...

[miiizen]

Perfect, thanks!

[Jojo-Schmitz]

Rebased to fix merge conflicts.
Please consider a timely merge.