MusicXML: add support for numerals #24174
Open
+389
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rettinghaus
changed the title
rettinghaus
force-pushed
the
xml/experiments
branch
from
411fb64
to
453f510
Compare
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 24, 2024
Backport of musescore#24174
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 24, 2024
Backport of musescore#24174
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 24, 2024
Backport of musescore#24174
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 24, 2024
Backport of musescore#24174
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 24, 2024
Backport of musescore#24174
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 24, 2024
Backport of musescore#24174
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 24, 2024
Backport of musescore#24174
rettinghaus
force-pushed
the
xml/experiments
branch
from
0867810
to
e93caa0
Compare
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 26, 2024
Backport of musescore#24174
miiizen
reviewed
Aug 29, 2024
| String numeralRoot = m_e.readText(); | ||
| String numeralRootText = m_e.attribute("text"); | ||
| // TODO analyze text and import as roman numerals | ||
| ha->setHarmonyType(HarmonyType::NASHVILLE); |
There was a problem hiding this comment.
We appear to have just switched the problem around - previously nashville numbers were imported as roman numerals, now roman numerals are imported as nashville numbers. It would be great if we could recognise numerals here, as we've lost export/import consistency for numerals with this PR.
There was a problem hiding this comment.
That is not entirely true, because the numeral element has been ignored until here, the old behavior for function hasn't changed. But I will add a basic check for Roman numerals in the text attribute.
| m_xml.tag("numeral-root", { { "text", textName } }, "1"); | ||
| m_xml.endElement(); | ||
| // only check for major or minor | ||
| m_xml.tag("kind", textName.at(0).isUpper() ? "major" : "minor"); |
There was a problem hiding this comment.
You could modify the code you've written below to read inversions to write them here.
rettinghaus
force-pushed
the
xml/experiments
branch
from
15c137f
to
a3ac0c5
Compare
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 19, 2024
Backport of musescore#24174
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Nashville number system in MusicXML import and export and adds basic support for Roman numerals.
Relates to #19508.