Skip to content

Commit

Permalink
fix CI for windows and use jenkins artifacst for wheels (NVIDIAGameWo…
Browse files Browse the repository at this point in the history
…rks#766)

Signed-off-by: Clement Fuji Tsang <[email protected]>
Caenorst authored Nov 23, 2023

Verified

This commit was signed with the committer’s verified signature.
jonathan-irvin Jonathan Irvin
1 parent e7c97f7 commit 396c9d0
Showing 4 changed files with 17 additions and 10 deletions.
9 changes: 6 additions & 3 deletions ci/gitlab_jenkins_templates/ubuntu_custom_build_CI.jenkins
Original file line number Diff line number Diff line change
@@ -98,8 +98,8 @@ spec:
"""
}
pythonVerTag = pythonVer.split('\\.').join('')
Integer pythonVerTagVal = pythonVerTag
pythonVerAbiTag = (pythonVerTagVal < 38) ? pythonVerTag + 'm' : pythonVerTag
Integer MinorVal = pythonVer.split('\\.')[1].toInteger()
pythonVerAbiTag = (MinorVal < 8) ? pythonVerTag + 'm' : pythonVerTag
kaolinVer = sh(script: "cat ./version.txt", returnStdout: true).trim()
baseWheelName = "kaolin-${kaolinVer}-cp${pythonVerTag}-cp${pythonVerAbiTag}"
wheelName = "${baseWheelName}-linux_x86_64.whl"
@@ -116,9 +116,12 @@ spec:
stage("Push wheel to volume") {
sh """
mkdir -p /mount_binaries/whl/torch-${torchVer}_cu${cudaTag}
mv ./${wheelName} /mount_binaries/whl/torch-${torchVer}_cu${cudaTag}/${wheelName}
cp ./${wheelName} /mount_binaries/whl/torch-${torchVer}_cu${cudaTag}/${wheelName}
"""
}
stage("Push wheel to artifact") {
archiveArtifacts artifacts: "${wheelName}"
}
}
stage("Push") {
targetImage.push()
14 changes: 11 additions & 3 deletions ci/gitlab_jenkins_templates/windows_wheels_CI.jenkins
Original file line number Diff line number Diff line change
@@ -16,7 +16,7 @@ currentBuild.description = sourceBranch + ": " + commitHash

gitlabCommitStatus("test-${configName}") {

podTemplate(cloud:'sc-ipp-blossom-prod',
podTemplate(cloud:'sc-ipp-blossom-116',
slaveConnectTimeout: 4000,
yaml: """
apiVersion: v1
@@ -28,7 +28,7 @@ spec:
claimName: 'kaolin-pvc'
containers:
- name: jnlp
image: jenkins/jnlp-agent:latest-windows
image: urm.nvidia.com/sw-ipp-blossom-sre-docker-local/jnlp-agent:jdk11-windows
env:
- name: JENKINS_AGENT_WORKDIR
value: C:/Jenkins/agent
@@ -41,7 +41,7 @@ spec:
- mountPath: c:/mnt
name: pvc-mount
imagePullSecrets:
- name: gitlabregcred
- name: gitlabcred
nodeSelector:
kubernetes.io/os: windows
"""
@@ -70,6 +70,14 @@ spec:
}
}
}
stage("Push wheels on artifacts") {
catchError(stageResults: "failure") {
powershell '''
cp /tmp/kaolin-*.whl .
'''
archiveArtifacts artifacts: "kaolin-*.whl"
}
}
}
}
}
2 changes: 0 additions & 2 deletions tools/windows/Dockerfile
Original file line number Diff line number Diff line change
@@ -3,8 +3,6 @@

FROM mcr.microsoft.com/dotnet/framework/sdk:4.8-windowsservercore-ltsc2019

SHELL ["powershell", "-Command", "$ErrorActionPreference = 'Stop'; $ProgressPreference = 'SilentlyContinue';"]

# set up conda and python environment
ARG CUDA_VERSION=11.1
ENV CUDA_VERSION=${CUDA_VERSION}
2 changes: 0 additions & 2 deletions tools/windows/Dockerfile.install_wheel
Original file line number Diff line number Diff line change
@@ -4,8 +4,6 @@
ARG BASE_IMAGE
FROM ${BASE_IMAGE}

SHELL ["powershell", "-Command", "$ErrorActionPreference = 'Stop'; $ProgressPreference = 'SilentlyContinue';"]

RUN python setup.py bdist_wheel --dist-dir /tmp

WORKDIR /tmp

0 comments on commit 396c9d0

Please sign in to comment.