Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pip installing the library in python 3 #37

Merged
merged 1 commit into from
Jun 26, 2019

Conversation

RobertLucian
Copy link
Contributor

This fixes the installation process for Python3. This is what I was getting before this fix:

    ERROR: Complete output from command python setup.py egg_info:
    ERROR: Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-install-xogkhbdz/kociemba/setup.py", line 5, in <module>
        long_description = open(os.path.join(os.path.dirname(__file__), 'README.md')).read()
      File "/home/pi/.venv/lib/python3.5/encodings/ascii.py", line 26, in decode
        return codecs.ascii_decode(input, self.errors)[0]
    UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 4166: ordinal not in range(128)
    ----------------------------------------
ERROR: Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-install-xogkhbdz/kociemba/

Also, I had to use the io module to make it compatible with Python 2.x too.

@muodov
Copy link
Owner

muodov commented Jun 24, 2019

Thanks for this @RobertLucian !
Sounds like this might fix #34 as well

@muodov
Copy link
Owner

muodov commented Jun 24, 2019

@RobertLucian
Copy link
Contributor Author

Great! Does this mean there's going to be a 1.2.1 out there?

@muodov muodov merged commit d0e4101 into muodov:master Jun 26, 2019
@noetejaxun
Copy link

:(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants