Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add execute() method to CubieCube #10

Closed
wants to merge 1 commit into from
Closed

Conversation

ansiwen
Copy link
Contributor

@ansiwen ansiwen commented Dec 28, 2015

No description provided.

@muodov
Copy link
Owner

muodov commented Dec 30, 2015

Hm, I might be wrong, but I think this execute() method won't be too helpful. I mean, CubieCube, FaceCube, and CoordCube are (currently) designed as internal structures for solving algorithm, and therefore they are not convenient for interactive programming.
I guess execute() method would be interesting within some kind of a "human-friendly" API, which is not really present for now. Moreover, this usecase is much better covered by PyCuber.

So what do you think of adding this as a desired functionality for pycuber integration?

@ansiwen
Copy link
Contributor Author

ansiwen commented Dec 30, 2015

I had to write this function in order to test my solve to pattern stuff anyway. So I though you might be interested in it. Could be useful also for testing results. Btw.: If I'm not mistaken, the tests only test the C implementation, not the Python one, right?

@muodov
Copy link
Owner

muodov commented Dec 30, 2015

Yeah, I'm planning to do a massive cleanup on the whole codebase later, and will add proper test suites for both implementations before that.

@ansiwen ansiwen closed this Dec 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants