fix: make sure DNS verification jobs are cancelled when use claims a …

…new username.

src/lib/dns/server.ts

@@ -454,7 +454,7 @@ export async function startDnsServer() {
 						// Don't go to next so that our normal default NS response doesn't get created.
 						// We're trying to emulate the way that authoritative nameservers won't respond
 						// to NS queries on subdomains that don't have custom nameservers.
-						return next();;
+						return next();
 					}
 			}
 

src/lib/server-globals.ts

@@ -16,4 +16,4 @@ import type { DefaultServer } from 'dinodns/common/server';
  * don't change _this_ file, which is not a problem because it exists only for exporting this
  * variable that never needs to change during development.
  * */
-export const serverGlobals: { dnsServer?: DefaultServer; cronJobs?: CronJob[] } = { };
+export const serverGlobals: { dnsServer?: DefaultServer; cronJobs?: CronJob[] } = {};

src/lib/usernames/index.ts

@@ -166,6 +166,9 @@ with value "${expectedValue}". Found other values: ${txtRecords.map((v) => `"${v
 				await unset(oldUsername);
 			}
 
+			// Be sure to kill any in-progress DNS verification jobs for this user.
+			await removeDomainVerificationJob(rauthyId);
+
 			return;
 		} catch (e) {
 			failures += 1;
@@ -379,5 +382,5 @@ export const usernames = {
 	cronJob,
 	setDomainVerificationJob,
 	getDomainVerificationJob,
-	removeDomainVerificationJob,
+	removeDomainVerificationJob
 };