Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore banned try solve discussions #201

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Chore banned try solve discussions #201

wants to merge 3 commits into from

Conversation

luchotc
Copy link
Contributor

@luchotc luchotc commented Mar 31, 2021

🎯 Goal

Try solve user discussions when it is banned from forum

🔙 Backwards compatibility

100%

@luchotc luchotc requested a review from flbulgarelli March 31, 2021 17:12
flbulgarelli
flbulgarelli reviewed Apr 9, 2021
View reviewed changes
Copy link
Member

@flbulgarelli flbulgarelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed this with Lucho and we think it would be better to add a ban! entry point with this new logic instead of using after_save.

He will evaluate the effort needed to do this refactor, and proceed with it or this PR as-is based on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flbulgarelli flbulgarelli flbulgarelli left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luchotc @flbulgarelli