Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add delegates inspection #195

Merged
merged 3 commits into from
Jan 1, 2019
Merged

Add delegates inspection #195

merged 3 commits into from
Jan 1, 2019

Conversation

flbulgarelli
Copy link
Member

@flbulgarelli flbulgarelli commented Jul 23, 2018 •
edited
Loading

Pending:

  • This expectation will be true when using recursion
  • There is some code duplication
  • Implementation may be simplified
  • It is not contextualizable - but was asked by @NadiaFinzi
  • It still has to be exposed and documented

Related to #194

@ghost ghost assigned flbulgarelli Jul 23, 2018
@ghost ghost added the pending-review label Jul 23, 2018
@julian-berbel julian-berbel changed the title Initial implementation Add delegates inspection Jul 24, 2018
@flbulgarelli
Copy link
Member Author

It is not contextualizable - but was asked by @NadiaFinzi

The contextualization thing is not as easy as I though - it involves some refactoring and renames, mostly because there are already Scope and binding words over there, but they meaning has not sense anymore. Those are legacy issues from mulang when it changed from the x0.x.x naming to v2.x.x naming.

@flbulgarelli flbulgarelli force-pushed the feature-#194-delegates-inspection branch from 3051c53 to f4f8ac7 Compare December 27, 2018 22:07
@ghost ghost added pending-review and removed paused labels Dec 27, 2018
@flbulgarelli flbulgarelli mentioned this pull request Jan 1, 2019
Closed
@flbulgarelli
Copy link
Member Author

flbulgarelli commented Jan 1, 2019 •
edited
Loading

This expectation will be true when using recursion

This issue should be considered as known-limitation, and address through contexts

It is not contextualizable - but was asked by @NadiaFinzi

Again, the contexts issue is out of scope. Moved to a separate issue #209

Merging.

@flbulgarelli flbulgarelli merged commit 6b5a943 into master Jan 1, 2019
@ghost ghost removed the pending-review label Jan 1, 2019
@flbulgarelli flbulgarelli deleted the feature-#194-delegates-inspection branch January 1, 2019 16:30
@flbulgarelli flbulgarelli mentioned this pull request Jan 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@flbulgarelli flbulgarelli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@flbulgarelli