FEAT(client): Restore RNNoise for version 0.2 #6607
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillermofbriceno
force-pushed
the
rnn2
branch
3 times, most recently
from
d5e9670
to
36e3c59
Compare
|
Just noticed I forgot to enable rnnoise so it builds by default, since it was originally turned off before Mumble switched to ReNameNoise. I had it turned on manually. Sorry in advance for prompting another build check. |
guillermofbriceno
force-pushed
the
rnn2
branch
from
36e3c59
to
7689a5d
Compare
guillermofbriceno
force-pushed
the
rnn2
branch
from
7689a5d
to
db9d1d9
Compare
Reverted the merge which added ReNameNoise as an RNNoise replacement. Added the git submodule from xiph/rnnoise after removing ReNameNoise. Chose to go with rnnoise's `main` here. Resolves mumble-voip#6395 Reverts mumble-voip#6364
guillermofbriceno
force-pushed
the
rnn2
branch
from
db9d1d9
to
b4024b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #6364 and adds the xiph/rnnoise repository at
main. This addresses #6395.There were a couple of requirements for this PR set by @Hartmnt in #6395 (comment). I do not have multiple platforms to test the build, but it works on my Linux host. Regarding examples, there are some good examples posted on the regression item. A friend and I did some light testing on Mumble and had similar results. I do not have the hardware to test on multiple audio devices.
Other than that, I think this fulfills the other requirements, but please let me know. Since this reverts an old merge, forgive me if there are style issues.
Checks