Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUILD(client): Report correct/current release version in overlay #5491

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

BUILD(client): Report correct/current release version in overlay #5491

wants to merge 3 commits into from

Commits on Jan 21, 2022

  1. BUILD(client): Report correct/current release version in overlay 

    Probably overlooked while cutting the release.
Reuse the main project's version number rather than hardcoding it.

Note 1.4.230 was released with an incorrect version number and therefore
builds as

```
-- ##################################################
-- Mumble version:          1.4.0
```

which is also visible in the final executable, e.g. prominently in the
window title (xprop(1) output):

```
WM_NAME(STRING) = "Mumble -- 1.4.0 | FOO"
_NET_WM_NAME(UTF8_STRING) = "Mumble -- 1.4.0 | FOO"
```

as well as the `Help > About... > About Mumble` menu.
    @klemensn
    klemensn committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    a3c9f8e View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2022

  1. Add debug statement

    @Krzmbrzl
    Krzmbrzl committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    47f9d83 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2022

  1. see if the call to project() changes CMAKE_PROJECT_VERSION 

    The previous debug commit proves CMAKE_PROJECT_VERSION=1.5.0 so WHY
does it not work a few lines down below?
    @klemensn
    klemensn committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    9fc66e0 View commit details
    Browse the repository at this point in the history